OpenRA / OpenRA/OpenRA

Useful info for rewriting BlowfishKeyProvider

Open
#7,325 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Refactor
Dominant language
C#
Stars
17.4k
Forks
3k
Avg merge
1d 12h
Merged PRs (30d)
14

Description

There is a comment in BlowfishKeyProvider.cs stating that it could use a rewrite. If anyone wants to do that, the information at http://www.ppmsite.com/forum/viewtopic.php?t=38717 will probably be useful as it explains what the code in BlowfishKeyProvider actually does and how to reimplement it using standard crypto libraries.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the comment and implementation in BlowfishKeyProvider.cs, then read the linked forum post to understand the existing behavior and its proposed standard-library approach. Done means replacing the provider with a standard cryptography-library implementation while retaining the behavior described in the issue; the payload names no tests to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cryptography
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.