Decoupling Player count from Spawn Points/"mpspawn" count.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 17.4k
- Forks
- 3k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 14
Description
My Sole Survivor mod currently uses custom MP Spawn traits and Lobby stuff in order to allow 60 players in a game regardless of spawn point count. Team members are spawned next to each other on one spawn, and if the spawn point count is reached, remaining players are randomly spread around. For the maps that come with the mod, this setup requires manual edit to the maps, so i was looking into if i can make the Map Editor and the new Map Generator automatically force this value and after some trial and error, it doesn't seem to be possible without engine changes, and SS for now have been using unedited upstream engine, unlike my other mods.
I'm not sure what other use cases might come out of such rework, and doing it properly might need too much work. I already have duplicate LobbyCommands and LobbyWidget in the mod to remove insufficientPlayerSpawns checks. If those checks could be made optional in upstream, it would spare me the headache to update those two pretty much every time i do an engine update.
For the map editor, i think what i need can be achieved by moving the stuff related to handling player count in EditorActorLayer to its own trait. Then i can replace that trait for Sole Survivor, because replacing EditorActorLayer itself doesn't seem to viable at the moment.
Map Generator is the part that i'm unsure about and would really like to have it working. I found the relevant code but dunno what would be a good way to make it customisable downstream without duplicating the whole thing. It is a new piece of code and i haven't been active around here in a good while. Wanted to drop this here before i attempt anything.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read EditorActorLayer and the existing LobbyCommands/LobbyWidget checks around insufficientPlayerSpawns, then trace the Map Generator code mentioned in the report. Determine an upstream extension point that lets downstream mods decouple player count from spawn-point count without duplicating these components. Done means the editor, generator, and lobby behavior support the requested customization without recurring mod copies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100