NewOptionsNotification should reside in ProductionQueue type traits
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 17.4k
- Forks
- 3k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 14
Description
In my mod intended to make EVA use different voices for announcing new Unit or Upgrades becoming available to build. This seems not possible as this Speech notification is tied to the PlaceBuilding trait, thus forced to be the same for all.
I can propose it be uncoupled from this PlaceBuilding trait, relocated into ProductionQueue type traits as a possible announcement, while at it might also decouple it from building placed, so when the field is given will announce the new options irrevelant if a building or unit has provided the prerequisites for making the new actors available for construction.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing NewOptionsNotification from the PlaceBuilding trait to the ProductionQueue type traits and identify how building placement triggers the announcement. Define the desired behavior for unit or upgrade availability, then verify that the notification can be configured independently of PlaceBuilding and prerequisites before adding focused tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100