OpenRA / OpenRA/OpenRA

Clients can connect before the hosting client connected to the lobby

Open
#19,204 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Networking
Dominant language
C#
Stars
17.4k
Forks
3k
Avg merge
1d 12h
Merged PRs (30d)
14

Description

Reported by a1fa on IRC:

[13:34:25] (a1fa) as openra client, you create a server... and while server is creating, another person attempting to join rapidly, will join before the hosting client

That means that the joining client will be the admin because the hosting person arrives later.

We should probably either only let people join after the host is in the lobby or reserve the admin spot for the game host.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the lobby connection and host/admin assignment behavior described in the report, focusing on the race where a joining client arrives before the host. Determine whether joining must wait for the host or whether the host's admin position should be reserved. Done means the host remains admin even when another client connects rapidly.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.