OpenPrinting / OpenPrinting/libcupsfilters
Provide translation for internal function from bannertopdf filter
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 17
- Forks
- 71
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 13
Description
Hallo.
In process for solving following issue https://github.com/OpenPrinting/libcupsfilters/issues/99 found that generate_banner_pdf function have untranslatable strings used for creating test print page:
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L689
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L695
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L701
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L706
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L709
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L714
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L717
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L723
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L729
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L734
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L739
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L784
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L790
https://github.com/OpenPrinting/libcupsfilters/blob/2.1.1/cupsfilters/bannertopdf.c#L795
libcupsfilters already include gettext dependency.
We can use translation domain presented in current repository for that?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect cupsfilters/bannertopdf.c around generate_banner_pdf and the listed lines to identify the untranslatable test-page strings. Read how the existing gettext dependency and translation domain are used elsewhere in the repository. Done means those strings use the appropriate translation mechanism and domain for localized output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- localization
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100