Support broadcasting in binary operators
Open
Nobody has claimed this yet.
enhancement
help wanted
- Dominant language
- C++
- Stars
- 4.7k
- Forks
- 536
- Avg merge
- 12h 12m
- Merged PRs (30d)
- 4
Description
The binary operators:
ops::Addops::Mulops::Sub
currently do not support broadcasting. One should instead call the lower level primitives such as add_depth_broadcast which require device and type dispatch.
The operators should be updated to at least support broadcasting on the first dimension (batch) and the last dimension (depth).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementations of ops::Add, ops::Mul, and ops::Sub, then read the lower-level add_depth_broadcast primitive and its device/type dispatch. Review any nearby tests and define coverage for broadcasting on the first and last dimensions; done means the operators support those cases without callers invoking lower-level primitives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100