OpenMathLib / OpenMathLib/OpenBLAS
Inquiry and Suggestions Regarding OpenBLAS Code Flow with OpenMP
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 7.6k
- Forks
- 1.7k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 42
Description
Hello,
I've been delving into the OpenBLAS codebase, specifically focusing on the gemm_driver function in level3_thread.c with the #USE_OPENMP=1 flag enabled. I've come across a section in the code where a lock is used in the Pthreads and Win32 backend before initializing and assigning the blasqueue. The lock is released only after the exec_blas call is completed.
My current understanding is :
- In the case of Pthreads The thread pool is initialized (POSIX), and when a BLAS call is made, the thread pool is utilized to execute it, after which the threads go back to sleep. The use of locks ensures that only one exec_blas call can be executed at a time.
- If I use a thread pool with
No_of_threads < nthreads(number of queue partitions) defined in level3_thread.c, I encounter a deadlock within the inner_threads function. - There seems to be significant busy-waiting (NOP) inside the inner_thread function call for thread synchronization.
I have a few questions and want to seek suggestions from the community:
-
I noticed that OpenMP locking mechanisms like omp_set_lock are not used, and instead, busy-waiting is implemented inside the exec_blas function in blas_server_omp.c using max_parallel_number. Could you please provide insights into this choice?
-
The inner_thread function appears to encounter deadlock when used with fewer threads. I tested this in OpenMP by creating a parallel region inside exec_blas in line 437 - blas_server_omp.c with a fixed number of threads less than nthreads. Could you shed some light on the reasons behind this behavior?
-
Considering the busy-waiting in the code, have there been considerations for putting threads to sleep or employing other synchronization methods to enhance efficiency?
I would appreciate clarification on these points.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing gemm_driver in driver/level3/level3_thread.c and exec_blas and inner_thread in driver/others/blas_server_omp.c. Reproduce the reported deadlock with fewer OpenMP threads than the queue partitions, then compare the locking and busy-waiting paths. Done would require a confirmed explanation and a clearly scoped synchronization change or documentation outcome.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- hpc, performance
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100