OpenMDAO / OpenMDAO/Aviary

Unify Stall Speed Calculations

Open
#385 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code cleanup
Dominant language
Python
Stars
287
Forks
140
Avg merge
6d 14h
Merged PRs (30d)
18

Description

Desired capability or behavior.

From @jdgratz10:
There are three different files where some calculation of stall speed is employed. The files are here, here, and here. We need to either unify our stall speed calculations to avoid code duplication, or be more clear about the differentiation if they cannot be unified.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the stall-speed calculations in aviary/mission/gasp_based/phases/landing_components.py, aviary/mission/gasp_based/ode/constraints/flight_constraints.py, and aviary/mission/flops_based/phases/simplified_takeoff.py. Determine whether the calculations are equivalent or require distinct explanations. Done means the duplicated logic is unified, or the necessary differences are made clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.