OpenMDAO / OpenMDAO/Aviary

Possible code duplication in propulsion

Open
#315 0 comments 0 reactions 1 assignee View on GitHub

@jkirk5 is already working on this.

Since Sep 30, 2024.

code cleanup
Dominant language
Python
Stars
287
Forks
140
Avg merge
6d 14h
Merged PRs (30d)
18

Description

Desired capability or behavior.

There are several places in propulsion where the code traverses a section of the variable hierarchy and assembles an AviaryValues object from multiple sources, typically from another object and the metadata defaults.

Each application is different but there may be common pieces that can be spun off into a utility function. Some files where this happens include propulsion.utils.py, engine_deck.py, engine_model.py, aviary_values.py

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.