Replace ParamPort with VariableIn
@Kenneth-T-Moore is already working on this.
Since Aug 21, 2024.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
The GASPy-based code currently uses a somewhat ad hoc mechanism for statically declaring the variables that need to be passed either from the user or from static analysis into the "phases" (referring to actual dymos phases and the analytic flight segments). It then functions as an input-only component in each ODE for other components to connect to via promotion and provides methods to resolve conflicting defaults and add them as parameters to the dymos trajectories.
Talked this through a bit with @crecine and @ehariton; we like the idea of naming the VariablesIn components when they're in the model to something like _dummy_component_for_inputs or something equally obvious what's going on.
Additionally, these components should move as far down in the model as possible to not create unnecessary backwards coupling from appearing in the n2.
Is your feature request related to a problem? Please describe.
No response
Associated Bug Report
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.