Nacelle physical dimensions do not scale with Engine.Scale_Factor
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Description
When Aviary scales an engine using Engine.SCALE_FACTOR the Thrust changes, and we do update some aspects of geometry (such as the wetted area), but we do not calculate and output the scaled length or diameter.
These linear dimensions scale approximately with sqrt(SCALE_FACTOR).
This scaling is already factored into wetted area, and cancels in the calculation of fineness ratio, so the aerodynamic subsystem will correctly factor in the scaled nacelle.
The landing gear calculations currently use the unscaled average diameter, but should use a scaled diameter:
The nacelle mass relationship currently uses the unscaled average length and average diameter.
We should check where else the Aircraft.Nacelle.AVG_DIAMETER is used and check if it should use a reference or scaled value.
Example
No response
Error Message
No response
Aviary Version
1.0.3-dev
Environment Information
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for Aircraft.Nacelle.AVG_DIAMETER and Engine.SCALE_FACTOR, then inspect the landing-gear and nacelle-mass calculations that use the average dimensions. Trace where nacelle length and diameter are calculated or output, and consider the work complete when scaled dimensions are available and all affected consumers use reference or scaled values appropriately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100