Move reasonable values logic out of fuselage component
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
The FLOPS based Fuselage component is large with big sections of logic block to setup reasonable values for the layout of the fuselage given inputs that are specified and inputs that are missing.
Perhaps we should move this logic into preprocessors, which would simplify the component and consolidate parts of aviary where 'default and/or reasonable values get set.
aviary/subsystems/geometry/flops_based/fuselage.py in the compute block.
There are also some shorter logic checks etc in the gasp_based/fuselage.py too.
Suggested implementation.
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in aviary/subsystems/geometry/flops_based/fuselage.py, focusing on the compute block that sets reasonable fuselage layout values, then inspect the shorter checks in gasp_based/fuselage.py. Trace how missing and specified inputs are handled before deciding which logic belongs in preprocessors. Done means the component logic is simplified, the reasonable-value behavior is consolidated, and existing behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100