OpenMDAO / OpenMDAO/Aviary

Move seat variables into better location in hierarchy

Open
#1,236 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Python
Stars
287
Forks
140
Avg merge
6d 14h
Merged PRs (30d)
18

Description

Desired capability or behavior.

Currently these variables:
Aircraft.CrewPayload.Design.NUM_SEATS_ABREAST_BUSINESS
Aircraft.CrewPayload.Design.NUM_SEATS_ABREAST_ECONOMY
Aircraft.CrewPayload.Design.NUM_SEATS_ABREAST_FIRST
Aircraft.CrewPayload.Design.SEAT_PITCH_BUSINESS
Aircraft.CrewPayload.Design.SEAT_PITCH_ECONOMY
Aircraft.CrewPayload.Design.SEAT_PITCH_FIRST

Are in a strange location in the hierarcy as they describe the aircraft configuration, not it's loading.

Suggest we move them to
Aircraft.Fuselage.NUM_SEATS_ABREAST_BUSINESS
Aircraft.Fuselage.NUM_SEATS_ABREAST_ECONOMY
Aircraft.Fuselage.NUM_SEATS_ABREAST_FIRST
Aircraft.Fuselage.SEAT_PITCH_BUSINESS
Aircraft.Fuselage.SEAT_PITCH_ECONOMY
Aircraft.Fuselage.SEAT_PITCH_FIRST

So that they sit alongside the SEAT_WIDTH variables.

This issue should include a discussions on the following:

  • Should we change Aircraft.CrewPayload.Design.NUM_BUSINESS_CLASS etc to be totals of the number of seats rather than the number of passengers on the 'design' mission. Maybe these should also be moved to Aircraft.Fuselage.* if we choose to do this.
  • Logic in preprocessors might need adjusting to check loading against the number of seats in the aircraft, not the number of passengers flown on the 'design' mission.
Suggested implementation.

Move them in variables.py and variable_mata_data.py then update everywhere they are referenced in the code and docs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in variables.py and variable_mata_data.py to understand the current definitions, then search the code and documentation for all listed variable references. Resolve the requested hierarchy move and the open questions about seat totals and preprocessor loading checks; done means the definitions, references, preprocessors, and docs consistently use the chosen locations and semantics.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.