drag for excrescences per component for FLOPS based aero
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Note from D.J. in SkinFrictionDrag of subsystems/aerodynamics/flops_based/skin_friction_drag.py: Per component not completely implemented in aviary 1.0. (LEAPS) Variable mission_skin_friction_drag_corrections_count is a vector over components and is added to the drag. This may be "dead weight" from FLOPS.
D.J.: Moving from LEAPS1 to LEAPS2, we dropped support for the FLOPS skin friction drag corrections table. Esentially, we collapsed the input table to a single scalar input value. This may have been a temporary workaround, but we never came back to it. If people want the level of control offered by the old FLOPS way of doing it, then things need to be refactored a bit in Aviary.
It is likely that we will drop this comment in the source code.
See note # 1184 in SkinFrictionDrag of subsystems/aerodynamics/flops_based/skin_friction_drag.py.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in subsystems/aerodynamics/flops_based/skin_friction_drag.py, at the SkinFrictionDrag note referenced by issue 1184, and inspect how mission_skin_friction_drag_corrections_count is handled. Determine whether the intended outcome is removing the outdated comment or restoring per-component FLOPS-style control; completion should address that scope consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100