Check if we need a code block in setup_trajectory_params()
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
Note from Ken: "As we use more builders, we may reach the point where we don't need to do these anymore."
See note # 1179 in setup_trajectory_params() of variable_info/functions.py.
I don't see anywhere that variables_to_add is used. Maybe, it is time to remove this code block? Otherwise, a unit test is needed.
Suggested implementation.
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in variable_info/functions.py at setup_trajectory_params() and inspect the note about variables_to_add. Search the repository to determine whether variables_to_add is used; done means either removing the unnecessary code block or adding a unit test that covers its required behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100