variables_to_add is required when calling setup_trajectory_params
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
Note from Ken: "variables_to_add is required, so should be an arg, not a kwarg."
See note # 1178 in setup_trajectory_params() of variables_info/functions.py. But we have never used variables_to_add when calling .setup_trajectory_params(). If we do use it, we need a unit test.
Suggested implementation.
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in variables_info/functions.py at setup_trajectory_params() and inspect its call sites to confirm how variables_to_add is currently passed or omitted. Check the surrounding unit tests, then update coverage for using variables_to_add; done means the required-argument behavior is explicit and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100