GASP engine pod mass definition does not match FLOPS
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
GASP engine pod mass is a combination of pylon and nacelle mass only. In FLOPS, engine pod mass includes everything inside the pod too (so nacelle/pylon plus engine, fraction of electronics, hydraulics, fuel system, etc.) The same Aviary variable can't be used for both definitions, so one needs to be chosen (and whether it's worth tracking both values separately).
Note about this in mass/gasp_based/fixed.py
Is your feature request related to a problem? Please describe.
No response
Associated Bug Report
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in mass/gasp_based/fixed.py, read the existing note and trace how the GASP engine pod mass and FLOPS pod mass definitions are represented. Determine whether one definition should be selected or both tracked, then update the relevant implementation and documentation so the chosen meaning is unambiguous and verify affected mass calculations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100