Standardize required altitude rate naming
@nathanperreau is already working on this.
Since Feb 9, 2026.
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
Summary of Issue
In some places in Aviary, we have multiple names for effectively the same thing: required_altitude_rate and roc_at_toc.
Pick one name -- probably the former as verbosity is helpful -- and use it everywhere.
Issue Type
- Bug
- Enhancement
- Code Cleanup
- Docs
- Miscellaneous
Is your feature request related to a problem? Please describe.
Thinking more about this now, this is slightly more complex than just renaming.
I'll put my thoughts here.
GASP- and FLOPS-based missions handle rate of climb at top of climb differently. Aviary currently has no constraint on the GASP side but it exists in the input decks. FLOPS-based has required_altitude_rate come in at the phase_info level. This is valid for any phase and is enforced as a path constraint across the whole phase, not just climb.
We might as well rework this so that:
- the required altitude rate is available to be enforced anywhere, not just a phase called
climb - it's handled in the same way for all types of missions with a constraint at the
add_design_variables()method level frommethods_for_level2.py - to do this, we'd need to compute
ALTITUDE_RATE_MAXas part of the GASP equations of motion, which is not currently the case
Associated Bug Report
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.