Address deprecation warning in EngineDeck
Open
@jkirk5 is already working on this.
Since Jul 13, 2026.
code cleanup
- Dominant language
- Python
- Stars
- 287
- Forks
- 140
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 18
Description
Desired capability or behavior.
Address the deprecation in engine_deck.py (currently line 1320), which states that we will not be accepting both SCALED_SLS_THRUST and SCALE_FACTOR provided for the same model. This is one of the later holdouts from when engines were switched from using SCALED_SLS_THRUST as the preferred scaling control to SCALE_FACTOR.
SCALED_SLS_THRUST should be a computed output only, so we want to avoid "overwriting" it with a specified value, which might mess up cases where SCALE_FACTOR is allowed to vary
Is your feature request related to a problem? Please describe.
No response
Associated Bug Report
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.