OpenLitterMap / OpenLitterMap/openlittermap-web

Worldcup, if 2 people have the same amount of litter, give them the same (shared) place

Open
#122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
134
Forks
42
PR merge metrics
No merged PRs in 30d

Description

At this moment, the worldcup has places like 1, 2, 3, 4 etc.
However, if 2 (or more) people have the same amount, then they should share that place.
For instance: 1, 2, 2, 4 etc.

It doesn't seem likely to happen, but trust me, it does happen :-D
See printscreen of 29/12/2020.
Schermafdruk 2020-12-29_19 57 12 (irfanview)

In this case, it should have been 1, 2, 3, 4, 4, 6.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the worldcup ranking calculation and inspect how places are assigned from litter totals. Use the screenshot and example in the issue as the expected behavior: tied totals share a place and subsequent places skip accordingly, such as 1, 2, 3, 4, 4, 6. Verify the ranking with a case containing ties.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.