OpenLightingProject / OpenLightingProject/rdm-app

URL paths featuring spaces don't get correctly escaped

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
18
Forks
12
PR merge metrics
No merged PRs in 30d

Description

http://raw.githubusercontent.com/OpenLightingProject/logos/master/web fitted/OLA-Logo-Fitted-48px%402x.png

I 13:04:41.031 fetching http://raw.githubusercontent.com/OpenLightingProject/logos/master/web fitted/OLA-Logo-Fitted-48px%402x.png
I 13:04:41.068 image fetch failed. http://raw.githubusercontent.com/OpenLightingProject/logos/master/web fitted/OLA-Logo-Fitted-48px%402x.png -> 404

Compared to:
13:04:40.652
fetching http://raw.githubusercontent.com/OpenLightingProject/logos/master/web%20fitted/OLA-Logo-Fitted-48px%402x.png

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code responsible for fetching the URL shown in the issue and check how spaces in its path are handled. Compare the failing URL containing a literal space with the working version using %20; done means paths with spaces are escaped before fetching and the provided image request no longer returns 404.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.