OpenLightingProject / OpenLightingProject/rdm-app

Don't allow duplicate manufacturer IDs to be imported

Open
#305 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
18
Forks
12
PR merge metrics
No merged PRs in 30d

Description

I'm not quite sure how this happened and maybe it's just a "feature" of the dev app server, but we really shouldn't end up with duplicate manufacturer ID entries in the database!

See https://github.com/OpenLightingProject/ola/issues/1837

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked OpenLightingProject/ola#1837 issue and tracing the manufacturer-ID import path in this repository. Confirm where duplicate records are accepted and define done as preventing duplicate manufacturer IDs during import, with coverage for the affected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.