OpenLightingProject / OpenLightingProject/rdm-app

Don't delete manufacturer IDs

Open
#291 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
18
Forks
12
PR merge metrics
No merged PRs in 30d

Description

It causes lots of knock ons if they're linked to other data like responders.

Check but I assume the manufacturer update process did this, if so maybe just report a warning and allow a manual deletion in the extremely rare case where it's actually required.

E.g.
5734388809596928
becomes
5631596510052352

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the manufacturer update process and tracing how an existing manufacturer ID is handled when its value changes. Check the related responder data and confirm that updates preserve IDs, report a warning instead of deleting them, and still allow an explicit manual deletion when required.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.