OpenLightingProject / OpenLightingProject/rdm-app
A missing manufacturer entry confuses responder moderation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
The admin homepage reports:
n Responders in the moderation queue
But when you click into it, it tells you there are no responders left to moderate.
This is because of:
https://github.com/OpenLightingProject/rdm-app/blob/7d35c769b219d0d346686448266a5128bffafa2e/templates/admin-moderate-responder.tmpl#L8
https://github.com/OpenLightingProject/rdm-app/blob/7d35c769b219d0d346686448266a5128bffafa2e/templates/admin-moderate-responder.tmpl#L143-L153
Showing a more obvious error would be good at least, or ideally skipping onto the next fixture.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with templates/admin-moderate-responder.tmpl, especially the linked lines 8 and 143-153, and compare how the moderation queue count is displayed with how a missing manufacturer is handled. Done means the page no longer presents a contradictory empty queue: it should show an obvious error or skip to the next fixture.
Written by the indexing model from the issue text.
Assessment
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100