OpenLightingProject / OpenLightingProject/open-fixture-library
Full wheel support in editor
Open
Nobody has claimed this yet.
component-editor
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
At the moment, wheel slots are automatically added when a WheelSlot capability with specified slotNumber references it. This somewhat works, but also poses some problems:
- Unused wheel slots are not removed
- Wheels must have the same name as the channel containing the
WheelSlotcapabilities (not a problem now, but will become problematic when editing) - Other channels referencing an existing wheel (like Wheel Slot Rotation) cannot specify the exact wheel, so the fixture test always fails
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the fixture test and the code that handles WheelSlot capabilities and slotNumber references. Trace how unused wheel slots, wheel names, and references from Wheel Slot Rotation are currently resolved. Done means the fixture test passes and all three listed wheel-handling problems are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100