OpenLightingProject / OpenLightingProject/open-fixture-library

Improve schema entities

Open
#604 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component-schema
Dominant language
JSON
Stars
258
Forks
100
Avg merge
11h 52m
Merged PRs (30d)
53

Description

While working on the GDTF import plugin (#592), I noticed some possible improvements on the entities allowed in our schema:

  • Add deg/s and rph units to RotationSpeed entity
  • Rename IrisPercent to Aperture → also rename Iris's openPercent property to aperture

Since the second point is a breaking change, we should think about adding some of the missing capability types from GDTF as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the schema entities involved in the GDTF import plugin (#592), especially RotationSpeed and Iris. Identify where the unit and property names are defined and where they are consumed, then assess the missing GDTF capability types before deciding the complete breaking-change scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.