OpenLightingProject / OpenLightingProject/open-fixture-library
Edit existing fixtures in fixture editor
Nobody has claimed this yet.
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
Basically, the editor should be prefilled with the existing fixture data. Submitting the fixture will
- create a pull request to edit the fixture (when submitted from the main open-fixture-library.org deployment)
- add a commit to the current branch (when submitted from a preview deployment) → this allows fixture submitters to edit their fixture again (e.g. if they forgot something)
Maybe we can also allow JSON editing in the online editor (with validation) for more experienced / developer-minded people.
As long as the editor doesn't support all features from our schema yet, editing should only be possible for fixtures that don't use unsupported features. This can be ensured with #311.
It should also be possible to submit the data as new fixture (i.e. to use a similar fixture as starting point when adding a new one). Thanks to @dimitre for the idea (#224)!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by reviewing the existing fixture editor and issue #311, then consider the related prior idea in #224. Done means existing supported fixtures can be edited or submitted as new fixtures, with deployment-specific submission behavior and validation as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100