OpenLightingProject / OpenLightingProject/open-fixture-library
Improve channel name RegExp in schema
Open
Nobody has claimed this yet.
component-schema
difficulty-easy
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
In the fixture editor (without Nuxt.js #416), the channel name is required to start with an uppercase letter or a number and then do not contain any words that indicate that it's a fine channel:
^[A-Z0-9]((?!\b[Ff]ine\b)(?!\d+(?:\\s|-|_)*[Bb]it)(?!MSB)(?!LSB).)*$
This should be directly in the schema.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the fixture editor schema that defines channel names and compare its current constraint with the regular expression in the issue. Verify that the schema requires an initial uppercase letter or number and rejects the listed fine-channel words, bit-width forms, MSB, and LSB.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100