OpenLightingProject / OpenLightingProject/open-fixture-library
Fixture Editor: Allow hex RDM ids
Open
Nobody has claimed this yet.
component-editor
difficulty-medium
priority-low
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
Allow either ([0-9]+) or (0x[0-9a-f]+) in the fixture editor for RDM manufacturer and model ids, to allow either a decimal or hexadecimal input (as rdm.openlighting.org also shows both variants). Also add a good validation message.
Afterwards, hex values should be converted into decimal values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start at the fixture editor's RDM manufacturer and model ID validation, then verify decimal and 0x-prefixed inputs, a useful validation message, and decimal output.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100