OpenLightingProject / OpenLightingProject/open-fixture-library
Visualization of colors/colorsStart/colorsEnd
Nobody has claimed this yet.
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
In the OFL fixture editor, if you put 3 (comma-separated) colors in a ColorPreset, it draws 3 circles for the 3 colors.
In the OFL fixture editor, if you have a range (colorsStart/colorsEnd), it draws all the start colors in a row, one circle each, then an ellipsis (...), then one circle each for the end colors.
On the OFL webpage (e.g., https://open-fixture-library.org/cameo/hydrabeam-100 channel "Color Macros"), a ColorPreset with multiple colors in an array is shown as a single circle, divided up into pie slices of the various colors.
On the OFL webpage (e.g., fixture https://open-fixture-library.org/showtec/horizon-8 channel "Macro Colors"), a ColorPreset with colorsStart/colorsEnd will also put both of those colors into one circle, divided up like pie slices.
(OFL doesn't seem to have any fixtures with both colorsStart/colorsEnd and an array of colors in these, so I don't know how they interact.)
I find the inconsistencies here to be confusing. I think what I'd expect is:
- ranges (start/end) should always use 2 circles, with an ellipsis between them; non-ranges should use a single circle
- multiple colors (in an array) should always use the colored pie slices
- the editor and webpage should be the same
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the OFL fixture editor and webpage, with examples for ColorPreset and colorsStart/colorsEnd but no source files or tests. First trace how these values are rendered in both interfaces. Done means the editor and webpage consistently display ranges and multiple colors according to the requested behavior, including their interaction when both forms are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nuxt
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100