OpenLightingProject / OpenLightingProject/open-fixture-library
Always set defaultValue when it makes sense
Nobody has claimed this yet.
- Dominant language
- JSON
- Stars
- 258
- Forks
- 100
- Avg merge
- 11h 52m
- Merged PRs (30d)
- 53
Description
Edit by @Fxedel:
- Make defaultValue required in the fixture editor, but add a checkbox "This channel has no meaningful default value" -> it can't be forgotten to enter a default value
- Maybe wait until help bubbles (#432) have been implemented before?
- Add defaultValues in all existing fixtures to channels where they are missing
- As soon as these points have been finished: Export
NULLin D::Light plugin if default value is not present
See discussion below.
Hi guys :)
it's not an issue, but more a request...
some availableChannels (like FX in MacAura) have a defaultValue parameter.
I don't know how other software does, but in D::Light this could be treated as HOME parameter.
DL can handle specific values like 0,HALF,FULL,NULL and all the range between 0-255
HOME parameter is useful in a personality to 'reset' the device and setting the shutter to open, and the Pan/Tilt to HALF is something I've found useful.
NULL is for functions that won't be touched by the HOME call
best regards,
nicolas
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the fixture editor, the existing fixture definitions, and the D::Light plugin mentioned in the issue. Review how availableChannels and defaultValue are represented, then use the checklist as the completion criteria: enforce or explicitly exempt defaults, add missing values, and export NULL where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- content, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100