OpenLightingProject / OpenLightingProject/open-fixture-library

Always set defaultValue when it makes sense

Open
#354 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component-editor component-fixture difficulty-easy help wanted
Dominant language
JSON
Stars
258
Forks
100
Avg merge
11h 52m
Merged PRs (30d)
53

Description


Edit by @Fxedel:

  • Make defaultValue required in the fixture editor, but add a checkbox "This channel has no meaningful default value" -> it can't be forgotten to enter a default value
    • Maybe wait until help bubbles (#432) have been implemented before?
  • Add defaultValues in all existing fixtures to channels where they are missing
  • As soon as these points have been finished: Export NULL in D::Light plugin if default value is not present

See discussion below.


Hi guys :)
it's not an issue, but more a request...

some availableChannels (like FX in MacAura) have a defaultValue parameter.

I don't know how other software does, but in D::Light this could be treated as HOME parameter.

DL can handle specific values like 0,HALF,FULL,NULL and all the range between 0-255

HOME parameter is useful in a personality to 'reset' the device and setting the shutter to open, and the Pan/Tilt to HALF is something I've found useful.
NULL is for functions that won't be touched by the HOME call

best regards,
nicolas

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the fixture editor, the existing fixture definitions, and the D::Light plugin mentioned in the issue. Review how availableChannels and defaultValue are represented, then use the checklist as the completion criteria: enforce or explicitly exempt defaults, add missing values, and export NULL where appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
content, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.