OpenLiberty / OpenLiberty/liberty-tools-eclipse
Attempt a stop of dev mode during terminate
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 16
- Forks
- 20
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 16
Description
Currently a "terminate" will kill the maven/gradle devmode process. A hook in dev mode will attempt to gracefully stop the server, but depending on when the terminate is issued, there could be marker files left around that are not cleaned up leading to issues when dev mode is started again (see https://github.com/OpenLiberty/ci.maven/issues/1696).
We should do two things:
- Attempt to override "terminate" on our process and issue a stop to dev mode rather than killing the process.
- Offer a "clean" config option to run a Maven/Gradle clean as part of the start command.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how terminate currently handles the Maven/Gradle dev mode process and how the dev mode stop hook is invoked. Review the marker-file cleanup behavior described in the linked ci.maven issue, then define completion as graceful stopping during terminate and an optional clean operation during start. No files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100