OpenLiberty / OpenLiberty/liberty-tools-eclipse

Broaden detection of "is this a Liberty project?" calculation

Open
#492 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

multi-module
Dominant language
Java
Stars
16
Forks
20
Avg merge
2d 9h
Merged PRs (30d)
16

Description

Today in io.openliberty.tools.eclipse.Project.classifyAsServerModule() we look for one of the Liberty config files in src/main/liberty/config.

To align with the other two IDEs, we could do a more maximal detection heuristic of:

  • look for config files in src/main/liberty/config (which we already do)
  • look for liberty-plugin-config.xml files.
  • look for liberty-maven-plugin configured in project or imported parent project (and in LTV, for example, we are careful to look in profiles & pluginManagement even) - Maven-only obviously

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in io.openliberty.tools.eclipse.Project.classifyAsServerModule() and inspect the existing detection for files under src/main/liberty/config. Compare the detection approaches used by the other IDEs, then implement coverage for liberty-plugin-config.xml and liberty-maven-plugin declarations in the project or imported parent, including profiles and pluginManagement. Done means all listed Liberty project indicators are recognized.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.