OpenLiberty / OpenLiberty/liberty-tools-eclipse

Failure in LibertyPluginSWTBotGradleTest.testDashboardDebugWithCustomConfigAction - widget not found

Open
#433 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing
Dominant language
Java
Stars
16
Forks
20
Avg merge
2d 9h
Merged PRs (30d)
16

Description

2023-09-08T19:44:40.2947775Z java.lang.RuntimeException: Unable to locate widget: Start parameters:
2023-09-08T19:44:40.2948419Z at io.openliberty.tools.eclipse.test.it.utils.MagicWidgetFinder.find(MagicWidgetFinder.java:1054)
2023-09-08T19:44:40.2949294Z at io.openliberty.tools.eclipse.test.it.utils.SWTBotPluginOperations.setCustomStartParmsFromShell(SWTBotPluginOperations.java:541)
2023-09-08T19:44:40.2950363Z at io.openliberty.tools.eclipse.test.it.utils.SWTBotPluginOperations.launchCustomDebugFromDashboard(SWTBotPluginOperations.java:523)
2023-09-08T19:44:40.2951532Z at io.openliberty.tools.eclipse.test.it.LibertyPluginSWTBotGradleTest.testDashboardDebugWithCustomConfigAction(LibertyPluginSWTBotGradleTest.java:428)

This failure was introduced by an earlier version of https://github.com/OpenLiberty/liberty-tools-eclipse/pull/428. It seemed to occur consistently on Linux in particular.

We decided to workaround the failure by configuring the tests to run in alphabetical order. Our guess is that the way to understand this fact is that the error is provoked by runningthe LibertyPluginSWTBotMavenTest tests before the LibertyPluginSWTBotGradleTest tests, and worked around when these are run in the opposite relative order, such that the Gradle tests are run first (it's conceivable there are other complicating factors, including possibly the other test classes).

Opening this issue to follow up on the failure, to understand it better. This will hopefully help us more generally under these SWTBot tests. It's not that running the tests in a predictable alphabetical order is necessarily bad, but we'd like to understand the failure while it's happening consistently, (as it was when merging the PR on top of the HEAD of https://github.com/OpenLiberty/liberty-tools-eclipse/commit/2fb4b6b2f3a87599c60e4571220eb593e5dd3cbe).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with LibertyPluginSWTBotGradleTest.testDashboardDebugWithCustomConfigAction and compare its execution with LibertyPluginSWTBotMavenTest. Trace SWTBotPluginOperations.launchCustomDebugFromDashboard, setCustomStartParmsFromShell, and MagicWidgetFinder.find around the reported failure, then reproduce the issue with different test orders. Done means the cause is understood and the tests no longer depend on the workaround ordering.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.