OpenLiberty / OpenLiberty/liberty-tools-eclipse

Add log/trace for case where plugin stop command times out

Open
#421 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
16
Forks
20
Avg merge
2d 9h
Merged PRs (30d)
16

Description

We have seen some intermittent failures in the new "testDashboardStopExternalServer" tests for the new "stop" function using LMP/LGP to stop a session not started by LTE.

It'd be nice to have some logging to go along with this failure. Do we see something problematic or is nothing at all even running in this process?

My naive attempt to add this: https://github.com/scottkurz/liberty-tools-eclipse/commit/5b331362be06621e73b4da34d19c0bcc39a6a197 doesn't really work. Unfortunately the IO read might end up blocking and preventing the Job's run() method from ever returning.

It seems the IO would have be done differently, on another thread and/or another library.

(Note the test output would still be kind of weird in that the process' output streams are all smashed together.. regardless of this one change idea.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running or reading the testDashboardStopExternalServer tests and the new stop function, then review the attempted logging change in commit 5b331362be06621e73b4da34d19c0bcc39a6a197. Done means timeout diagnostics are captured without blocking the Job's run() method, with the intermittent failure providing useful process output.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.