OpenLiberty / OpenLiberty/liberty-tools-eclipse

Determine if LTE requires custom handling of the Maven wrapper with multi-module Maven projects.

Open
#347 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement multi-module should-fix
Dominant language
Java
Stars
16
Forks
20
Avg merge
2d 9h
Merged PRs (30d)
16

Description

PROBLEM

Multi-mod Maven case doesn't allow launch from "child" directory using mvnw wrapper from parent.
Say I have a multi-mod Maven structure like:

parent
 + pom.xml
 + mvnw
 + war
      + pom.xml
      + src/main/liberty/config/server.xml
      ....
 + jar
      pom.xml
      ...

In Liberty Tools Eclipse, I can run from the parent project and use the default parms (which is an empty list) and get mvnw liberty:dev, i.e. it'll use the mvnw wrapper in the root.

However, if I try to run from the 'war' level, I'll get default parms of ( ... -f ../pom.xml -pl war). However there's no way to pick up mvnw.

IDEA

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the child-project command described in the issue: a war module using -f ../pom.xml -pl war while the mvnw wrapper is in the parent directory. Review the discussion in issue 210 about displaying the full generated command, then define and test the expected wrapper lookup behavior for multi-module projects.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.