OpenLiberty / OpenLiberty/liberty-tools-eclipse
Determine if LTE requires custom handling of the Maven wrapper with multi-module Maven projects.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 16
- Forks
- 20
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 16
Description
PROBLEM
Multi-mod Maven case doesn't allow launch from "child" directory using mvnw wrapper from parent.
Say I have a multi-mod Maven structure like:
parent
+ pom.xml
+ mvnw
+ war
+ pom.xml
+ src/main/liberty/config/server.xml
....
+ jar
pom.xml
...
In Liberty Tools Eclipse, I can run from the parent project and use the default parms (which is an empty list) and get mvnw liberty:dev, i.e. it'll use the mvnw wrapper in the root.
However, if I try to run from the 'war' level, I'll get default parms of ( ... -f ../pom.xml -pl war). However there's no way to pick up mvnw.
IDEA
- Can we try to look for 'mvnw' in the parent/containing folder?
- Should we only do such a check if we see a relative path like
../pom.xmlas the-fparm value? - Does this steer us towards the need of a display of the full generated command? : https://github.com/OpenLiberty/liberty-tools-eclipse/issues/210
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the child-project command described in the issue: a war module using -f ../pom.xml -pl war while the mvnw wrapper is in the parent directory. Review the discussion in issue 210 about displaying the full generated command, then define and test the expected wrapper lookup behavior for multi-module projects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100