OpenLiberty / OpenLiberty/liberty-tools-eclipse
Liberty Tools command validation should validate fully-qualified dev mode invocation too
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 16
- Forks
- 20
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 16
Description
Currently we have a validation check on a user's custom cmd which is coded like:
if (startParamStr.contains("liberty:dev") || startParamStr.contains("libertyDev")) {
This detects if the user is trying to specify the dev goal/task themselves (which is wrong since the Liberty Tools function is supplying this).
But it might also be helpful to validate that the user isn't creating a custom cmd like: io.openliberty.tools:liberty-maven-plugin:3.7.1:dev
NOTE: This would be superseded by an enhancement as discussed in git@github.com:OpenLiberty/liberty-tools-vscode.git
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the custom-command validation that checks for "liberty:dev" or "libertyDev" and review how commands are parsed. Add coverage for the fully qualified io.openliberty.tools:liberty-maven-plugin:3.7.1:dev form, then verify that it is rejected without affecting valid custom commands.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100