OpenLiberty / OpenLiberty/ci.docker

Update template for application image to be consistent with Starter and guide

Open
#318 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

containers zenhub-dev
Dominant language
Shell
Stars
48
Forks
60
Avg merge
3h 2m
Merged PRs (30d)
3

Description

The template for a Dockerfile or Containerfile noted in the README does the below atm:

Add app

COPY --chown=1001:0 Sample1.war /config/dropins/

Should update it to be like the below to be consistent with what is generated by the Starter (start.openliberty.io) and what is covered in the Containerize guide (https://openliberty.io/guides/containerize.html#creating-your-dockerfiles):

COPY --chown=1001:0
target/guide-containerize-inventory.war
/config/apps

This aligns with the more common pattern. The server.xml will need a configuration too.

Cc @leochr

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The current template is in the README, and the issue provides the replacement Dockerfile or Containerfile snippet. Start by locating that template and comparing it with the Starter output and Containerize guide; also inspect the related server.xml example. Done means the documented image template and webApplication configuration match the stated pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
devops, documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.