OpenLiberty / OpenLiberty/ci.common
Binary scanner exception reorganization
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4
- Forks
- 32
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 5
Description
All those exceptions in ci.common BinaryScannerUtil extend Exception. It might be good if they all extended a common exception class so we could say "catch (BinaryScannerException)" or "if (e instanceof BinaryScannerException)" as we almost need to do in dev mode. Our code might be clearer if we actually did this next instead of as it is now assuming if it is not a binary scanner jar missing exception then it is a binary scanner operating exception.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate BinaryScannerUtil and its exception declarations in ci.common, then trace the current missing-jar and operating-exception handling, including the dev-mode checks mentioned in the issue. Define a shared BinaryScannerException hierarchy and update the relevant catches or instanceof checks; done means binary-scanner exceptions can be handled through the common type without changing unrelated exceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100