[bug] Openkore dont use price to check if can buy item
Nobody has claimed this yet.
- Dominant language
- Perl
- Stars
- 1.5k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Openkore version git
63d265c787ca3d0f0ad0530e4a8e8c1f154abfe3
XKore Mode
Empty
RO Server Name
Any
Link to RO server
anyserver.com
Result
there is a missing price check on auto buy leading openkore to endless loop trying to buy some item when it dont have the necessary zeny
Relevant Log Output
Expected Result
check price key in auto buy function
How to Reproduce
just add some item that openkore cant buy because of missing zeny and it will end up on a loop even when price key is set
Example:
# Gakkung
buyAuto_1 1714
buyAuto_1_npc payon_in01 15 119
buyAuto_1_npc_steps b
buyAuto_1_isMarket 0
buyAuto_1_distance 5
buyAuto_1_price 43000
buyAuto_1_minAmount 1
buyAuto_1_maxAmount 1
buyAuto_1_notInMap new_1-1, new_1-2, new_1-3, new_1-4, prontera
this can fix, but variables should be checked
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the loop with an auto-buy entry such as the Gakkung configuration, especially buyAuto_1_price and a character without enough zeny. Trace the auto-buy entry point and verify that the configured price and related variables are checked before another purchase attempt; done means the loop stops when the item cannot be afforded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100