OpenKore / OpenKore/openkore

Random item, player and monster detection issue

Open
#3,749 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug need info
Dominant language
Perl
Stars
1.5k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

  • Openkore version git:
    OpenKore what-will-become-2.1 ( version git:26c1a36_2023-04-27 ctime:2023_04_07 )
  • Server:
    Private Server(serverType kRO_RagexeRE_2015_11_04a)
  • Bug Report / Feature Request:
    Openkore randomly and incorrect detects Items in inventory:
    screenshot1
    From the screenshot above the item# 20 is actually blue herb when you login to check the inventory of the character
    screenshot2
    On this screenshot it detected Stem a non-usable item to have an upgrade
    From the screenshot above it cause this scenarios:
  1. The full inventory is messed up and openkore will call autostorage thinking items needed to be present in the inventory are not are not there ei. healing potions, awakening etc.
    Openkore randomly detects monsters and players as NPC:
    screenshot3
    C******E is the player is masked her name for her own protection 😆
    This usually happens when I this appears in the console:
    screenshot4
  • Summary:
    This is my server setup:
ip XX.XX.XXX.XXX
port 6900
master_version 1
version 55
serverType kRO_RagexeRE_2015_11_04a
secureLogin 0
secureLogin_type 0
secureLogin_requestCode
secureLogin_account 0
serverEncoding Western
storageEncryptKey 0x050B6F79, 0x0202C179, 0x0E20120, 0x04FA43E3, 0x0179B6C8, 0x05973DF2, 0x07D8D6B, 0x08CB9ED9
addTableFolders kRO/RagexeRE_2015_11_04a;translated/kRO_english
charBlockSize 147
pinCode 1104
charDeleteDateType 1
blockingPlayerCancel 1
rankingSystemType 1
itemListType 1
ignoreAntiCheatWarning 0
private 1
sendCryptKeys 0x4C17382A, 0x29961E4F, 0x7ED174C9

At first I thought the recvpackets.txt are wrong. So I went digging in the wiki and let me to PEEK's extraction method since my exe is more than 6MB (14mb to be exact). After successfully getting the recvpackets, I did some test run and issue persisted. I also notice that the recvpackets.txt are exactly the same as the ones from kRO_RagexeRE_2015_11_04a.

I have noticed a few scenarios where it is happening.

  1. When openkore relogs there is a higher chance this will happen, I noticed this since by old practice, I always enable relogAfterStorage. And so I disabled it. But it still happens.
  2. When openkore experiences timeout and reconnects, when my internet timeouts for a bit.
  3. Since my private server has @autoloot feature, it randomly happens when item is added in the inventory. This made me curious and so I set itemsTakeAuto 0 and all 0 in pickupitems.txt. Still issue happens.

My temporary fix is to close and open the executable until it happens again.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reported serverType configuration and recvpackets.txt, then reproduce inventory updates and player/monster detection across relogins, reconnects, and item pickup. Compare the observed packets with the decoded inventory and entity results; done means items and entities remain correctly identified in those scenarios.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
game-dev, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.