OpenKore / OpenKore/openkore

Plan how to refactor more things into Actor objects and ActorLists

Open
#356 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code cleaning discussion
Dominant language
Perl
Stars
1.5k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

This is for discussion and planning of possible naming and ways to set up everything. Propose everything there.

vending shops around

buying stores around

chatrooms around

users in current chatroom

For this and the following:

  • Something like Actor::Contact?
  • How to link this best with Actor::Player objects?
  • There is related chat channel, make it its own object class (to handle global chat, party chat etc) and put the list inside of it? Like $party->{users}, where $party would be a ChatChannel/ChatRoom object.
  • Probably could be compared with contacts in some messenger contact list to make a solid logic.

users in friend list

users in current party

users in current guild

items in arrow craft list

  • Temporary lists like this one, where to store? Would it just be always there but empty, or maybe dynamically created - then we need hook points to detect when actor lists are created and destroyed.
  • Actually temporary lists can be stored somewhere in the module which would handle the related stuff, but there needs to be some API to access them besides commands.

items in card merge list

items in identification list

items in current vending shop

  • Actor classes in such lists should have additional methods for actions with the item. Like ->buy($amount).

items in current buying shop

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing Actor and ActorList concepts and the issue's proposed vending, buying, chatroom, party, guild, friend, and item lists. Define naming, ownership, lifecycle, and access decisions for these objects, then record an agreed plan for the refactor and its APIs in the discussion.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.