OpenKore / OpenKore/openkore

Itemlink (ITEML) for 2020 clients

Open
#3,541 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request help wanted
Dominant language
Perl
Stars
1.5k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

  • Openkore version git: ec5091eefefb40e984224382c58a4957753c8507
  • Server: Local test, rAthena, serverType kRO_RagexeRE_2020_04_01b
  • Bug Report / Feature Request: Feature Request
  • Summary:

Follow up the sub solveItemLink since #2541,
on 2020 client (or idk since when exactly), the message pattern was changed for the separators as

older clients

  • card: (
  • options:
    • id: *
    • param: +
    • val: ,

2020+ client

  • card: )
  • options
    • id: +
    • param: ,
    • val: -

I don't know how to place or better implementation to support those differences.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the sub solveItemLink implementation mentioned in the issue and review the context from #2541. The change is complete when ITEML messages from 2020 clients and older clients are both parsed using their respective card and option separators.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.