[bug] Task SitStand infinity looping
Open
Nobody has claimed this yet.
bug
need info
- Dominant language
- Perl
- Stars
- 1.5k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
- Openkore version git:
https://github.com/OpenKore/openkore/commit/5e8e3001b1afbfa426d0550122dfd64261c6f014 - Server:
All - Bug Report:
Task SitStand lost char reference - Summary:
Sometimes the Task SitStand lost the char reference and don't know if char is sitting/stand and enter in a infinity loop
screenshot:
this was fixed in SitStand.pm changing from:
unless ($self->{mode} eq 'sit' xor $self->{actor}{sitting}) {
to:
unless ($self->{mode} eq 'sit' xor $char->{sitting}) {
my guess is, this task receive a copy of $char var and not a $char reference
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SitStand.pm and inspect how the task checks the character's sitting state while handling the sit/stand mode. Reproduce or review the reported infinity loop, then verify that the task retains and checks the current character state so it exits the loop correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100