OpenImagingLab / OpenImagingLab/FlashVSR

[Question] Clarification on 'sparse_ratio' and 'kv_ratio': Impact on Quality vs. Speed

Open
#58 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
152
PR merge metrics
No merged PRs in 30d

Description

Hi there,

I am currently using FlashVSR for video super-resolution and tuning the inference configuration. I observed a trade-off between speed and parameter settings, and I would like to confirm the best practices for achieving the highest possible quality.

My Observation:
When I increased the sparse_ratio from 4.5 to 10.0:

  • The inference speed increased from 1.03 it/s to 1.15 it/s (on a 60s video).
  • The speed improved, but I am concerned about the potential loss in reconstruction quality.

My Questions:
Since my priority is Quality > Speed, could you please clarify the following:

  1. sparse_ratio: Does a higher value mean higher sparsity (less computation) and therefore lower quality? Should I decrease this value (e.g., to < 4.5) to get better details?
  2. kv_ratio: Similarly, for kv_ratio (currently testing 3.0), does a smaller value result in better quality?
  3. Recommendation: If I want the best possible visual result and do not care about inference time, what range of values would you recommend for these two parameters?

Thank you for your hard work on this project!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names FlashVSR's sparse_ratio and kv_ratio inference parameters but mentions no files, tests, or entry points. Start by locating the definitions or documentation for these parameters; done would be a documented, maintainer-confirmed explanation of their quality and speed trade-offs and recommended values.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.