OpenHands / OpenHands/software-agent-sdk
[Bug]: TS client drops acp_isolate_data_dir from ACP settings payloads
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 539
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 137
Description
Bug Description
ACP_SETTINGS_KEYS in clients/typescript/src/models/acp.ts omits acp_isolate_data_dir, so the TypeScript client never forwards the per-conversation CLI data-dir isolation flag even though the Agent Server accepts it. (Related earlier report without template sections: #4907.)
Actual Behavior
The server side supports the field:
python -c "from openhands.sdk.settings.model import ACPAgentSettings; print('acp_isolate_data_dir' in ACPAgentSettings.model_fields)"
# True
But filtering a settings payload through the client's allow-list drops it:
cd clients/typescript && npm test -- src/__tests__/acp-providers.test.ts
# ACP_SETTINGS_KEYS › keeps the isolation flag when filtering a settings payload — fails on main
Expected Behavior
acp_isolate_data_dir is forwarded like the other ACP settings keys.
Acceptance Criteria
-
'acp_isolate_data_dir'is inACP_SETTINGS_KEYSinclients/typescript/src/models/acp.ts. - A filtered settings payload keeps
acp_isolate_data_dir: true. - Existing
clients/typescriptunit tests still pass.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in clients/typescript/src/models/acp.ts and inspect ACP_SETTINGS_KEYS, then run clients/typescript/src/tests/acp-providers.test.ts. Done means the allow-list preserves acp_isolate_data_dir: true and the existing clients/typescript unit tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 93/100