OpenHands / OpenHands/software-agent-sdk

fix: preserve repository identity in PR linked-issue readiness checks

Open
#5,027 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug ci priority:medium ready-for-dev
Dominant language
Python
Stars
1.1k
Forks
539
Avg merge
1d 19h
Merged PRs (30d)
137

Description

Actual Behavior

Run python .github/scripts/check_pr_description.py on a PR whose Issue Number section contains Fixes OpenHands/OpenHands#17236 (SDK PR #4931). The checker reports no linked issue even though the linked issue exists and has ready-for-dev. A qualified reference in the Issue Number section can also be mistaken for a local issue with the same number.

Desired Behavior

Extend the existing linked-issue parser and readiness check to preserve the repository in GitHub shorthand references. Reuse the same parser for linked-PR refresh so foreign issues cannot accidentally trigger checks for a same-number local issue. Do not create duplicate tracking issues to satisfy the validator.

Acceptance Criteria
  • Unqualified #123 continues to resolve in the PR repository.
  • owner/repo#123 after a closing keyword or in Issue Number resolves in the named repository.
  • Deduplication uses repository and number, and missing/unready foreign references do not pass as local references.
  • Existing linked-PR refresh retains local behavior without confusing foreign numbers.
  • Focused parser/validation/refresh tests cover local and cross-repository references. Ready-for-dev when these criteria pass the repository readiness check.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read .github/scripts/check_pr_description.py and trace the linked-issue parser, readiness validation, and linked-PR refresh. Add focused tests covering local and owner/repo#number references, repository-aware deduplication, and missing or unready foreign issues; done means the acceptance criteria pass the repository readiness check.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
ci-cd, testing-qa, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.