OpenFreeEnergy / OpenFreeEnergy/openfe
openff-units 0.2.1 giving typing errors
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 331
- Forks
- 56
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 13
Description
moving from 0.2.0 to 0.2.1 I get:
openfe/protocols/openmm_utils/settings_validation.py:15: error: Name "unit.Quantity" is not defined [name-defined]
openfe/protocols/openmm_utils/settings_validation.py:40: error: Name "unit.Quantity" is not defined [name-defined]
openfe/protocols/openmm_utils/settings_validation.py:41: error: Name "unit.Quantity" is not defined [name-defined]
openfe/protocols/openmm_rfe/equil_rfe_settings.py:456: error: Name "unit.Quantity" is not defined [name-defined]
openfe/protocols/openmm_rfe/equil_rfe_settings.py:464: error: Name "unit.Quantity" is not defined [name-defined]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the reported annotations and imports in openfe/protocols/openmm_utils/settings_validation.py at lines 15, 40, and 41, then openfe/protocols/openmm_rfe/equil_rfe_settings.py at lines 456 and 464. Reproduce the typing errors with openff-units 0.2.1 and compare the relevant API or typing behavior with 0.2.0; done means those reported name-defined errors no longer occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100