OpenFreeEnergy / OpenFreeEnergy/openfe
improve Warehouse validation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 331
- Forks
- 56
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 13
Description
Just food for thought, does not block... If a warehouse is partially corrupted, does this work? For example, if the default is exist_ok is False, what happens when someone accidentally deletes a single store, is the convention to just recreate the whole store? Is this worth caring about?
Originally posted by @ethanholz in https://github.com/OpenFreeEnergy/openfe/pull/2155#discussion_r3824730495
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the warehouse validation and checking the exist_ok=False path when a single store is missing. Clarify whether a partially corrupted warehouse should recreate only the missing store or the whole store, then define the expected behavior before changing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100