OpenFreeEnergy / OpenFreeEnergy/openfe
unify positive int (and float) handling
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 331
- Forks
- 56
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 13
Description
we should either use field_validator or Annotated[int, gt(0)] everywhere.
- n_restart_attempts
- constraint_tolerance (this one is a float, not an int)
- check other instances where we have
field_validatorcode duplication.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the n_restart_attempts and constraint_tolerance locations linked from pull request 1535, then search the project for other duplicated field_validator usage. The work is done when positive integer and float validation follows one consistent approach everywhere identified by the review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100